Re: [PATCH 4/4] arch: arm64: ti: Add support for J784s4 EVM board

From: Vignesh Raghavendra
Date: Wed Aug 24 2022 - 01:33:35 EST


Hi Krzysztof,

On 24/08/22 10:36, Nishanth Menon wrote:
> On 13:21-20220823, Krzysztof Kozlowski wrote:
>>> +
>>> +/ {
>>> + compatible = "ti,j784s4-evm", "ti,j784s4";
>>> + model = "Texas Instruments J784S4 EVM";
>>> +
>>> + chosen {
>>> + stdout-path = "serial2:115200n8";
>>> + bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x2880000";
>>
>> earlycon is not a property of hardware. Console is defined in

earlycon is helpful for debugging early crashes. How is it any different
from "console =" property as described in
Documentation/devicetree/usage-model.rst?

>> stdout-path, so please drop entire bootargs.
>
> We will probably have to cleanup elsewhere as well - point noted.
>

Whats the alternative to pass default bootargs to kernel if bootloader
does not pass bootargs via cmdline? I see quite a few dts file use
bootargs = "earlycon" at least


--
Regards
Vignesh