Re: [PATCH 19/20] EDAC/synopsys: Unify the driver entities naming
From: kernel test robot
Date: Tue Aug 23 2022 - 21:15:35 EST
Hi Serge,
I love your patch! Yet something to improve:
[auto build test ERROR on ras/edac-for-next]
[also build test ERROR on robh/for-next linus/master v6.0-rc2 next-20220823]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Serge-Semin/EDAC-mc-synopsys-Various-fixes-and-cleanups/20220823-031020
base: https://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git edac-for-next
config: arm-buildonly-randconfig-r006-20220823 (https://download.01.org/0day-ci/archive/20220824/202208240904.liSrmM2A-lkp@xxxxxxxxx/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/9c500fa8dbd08021742d8f5a48403c8f6292741c
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Serge-Semin/EDAC-mc-synopsys-Various-fixes-and-cleanups/20220823-031020
git checkout 9c500fa8dbd08021742d8f5a48403c8f6292741c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/edac/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
drivers/edac/synopsys_edac.c: In function 'snps_enable_irq':
>> drivers/edac/synopsys_edac.c:398:36: error: 'SYNPS_ZYNQMP_IRQ_REGS' undeclared (first use in this function); did you mean 'SNPS_ZYNQMP_IRQ_REGS'?
398 | if (priv->p_data->quirks & SYNPS_ZYNQMP_IRQ_REGS) {
| ^~~~~~~~~~~~~~~~~~~~~
| SNPS_ZYNQMP_IRQ_REGS
drivers/edac/synopsys_edac.c:398:36: note: each undeclared identifier is reported only once for each function it appears in
drivers/edac/synopsys_edac.c: In function 'snps_disable_irq':
drivers/edac/synopsys_edac.c:419:36: error: 'SYNPS_ZYNQMP_IRQ_REGS' undeclared (first use in this function); did you mean 'SNPS_ZYNQMP_IRQ_REGS'?
419 | if (priv->p_data->quirks & SYNPS_ZYNQMP_IRQ_REGS) {
| ^~~~~~~~~~~~~~~~~~~~~
| SNPS_ZYNQMP_IRQ_REGS
drivers/edac/synopsys_edac.c: In function 'snps_get_dtype':
drivers/edac/synopsys_edac.c:485:18: error: implicit declaration of function 'FIELD_GET'; did you mean 'FOLL_GET'? [-Werror=implicit-function-declaration]
485 | regval = FIELD_GET(DDR_MSTR_DEV_CFG_MASK, regval);
| ^~~~~~~~~
| FOLL_GET
drivers/edac/synopsys_edac.c: In function 'snps_mc_init':
drivers/edac/synopsys_edac.c:600:32: warning: variable 'priv' set but not used [-Wunused-but-set-variable]
600 | struct snps_edac_priv *priv;
| ^~~~
cc1: some warnings being treated as errors
vim +398 drivers/edac/synopsys_edac.c
ae9b56e3996dad Punnaiah Choudary Kalluri 2015-01-06 392
9c500fa8dbd080 Serge Semin 2022-08-22 393 static void snps_enable_irq(struct snps_edac_priv *priv)
4bcffe941758ee Sherry Sun 2022-04-27 394 {
b8ee875dfc73be Serge Semin 2022-08-22 395 unsigned long flags;
b8ee875dfc73be Serge Semin 2022-08-22 396
4bcffe941758ee Sherry Sun 2022-04-27 397 /* Enable UE/CE Interrupts */
b8ee875dfc73be Serge Semin 2022-08-22 @398 if (priv->p_data->quirks & SYNPS_ZYNQMP_IRQ_REGS) {
4bcffe941758ee Sherry Sun 2022-04-27 399 writel(DDR_QOSUE_MASK | DDR_QOSCE_MASK,
4bcffe941758ee Sherry Sun 2022-04-27 400 priv->baseaddr + DDR_QOS_IRQ_EN_OFST);
4bcffe941758ee Sherry Sun 2022-04-27 401
b8ee875dfc73be Serge Semin 2022-08-22 402 return;
b8ee875dfc73be Serge Semin 2022-08-22 403 }
b8ee875dfc73be Serge Semin 2022-08-22 404
b8ee875dfc73be Serge Semin 2022-08-22 405 /* IRQs Enable/Disable feature has been available since v3.10a */
b8ee875dfc73be Serge Semin 2022-08-22 406 spin_lock_irqsave(&priv->lock, flags);
b8ee875dfc73be Serge Semin 2022-08-22 407
b8ee875dfc73be Serge Semin 2022-08-22 408 writel(ECC_CTRL_EN_CE_IRQ | ECC_CTRL_EN_UE_IRQ,
b8ee875dfc73be Serge Semin 2022-08-22 409 priv->baseaddr + ECC_CLR_OFST);
b8ee875dfc73be Serge Semin 2022-08-22 410
b8ee875dfc73be Serge Semin 2022-08-22 411 spin_unlock_irqrestore(&priv->lock, flags);
4bcffe941758ee Sherry Sun 2022-04-27 412 }
4bcffe941758ee Sherry Sun 2022-04-27 413
--
0-DAY CI Kernel Test Service
https://01.org/lkp