Re: [PATCH v4] regulator: dt-bindings: mediatek: add mt6366

From: Nícolas F. R. A. Prado
Date: Tue Aug 23 2022 - 15:46:02 EST


On Tue, Aug 23, 2022 at 08:37:45PM +0800, Zhiyong Tao wrote:
> Add mt6366 regulator document
>
> Signed-off-by: Zhiyong Tao <zhiyong.tao@xxxxxxxxxxxx>
> ---
[..]
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-regulator.yaml
[..]
> + "^buck-(vcore)-sshub$":

The parentheses here don't serve any purpose, so drop them.

> + type: object
> + $ref: regulator.yaml#
> + unevaluatedProperties: false
[..]
> + "^ldo-vcn(33)-wifi$":

Ditto.

> + type: object
> + $ref: regulator.yaml#
> + unevaluatedProperties: false
> +
> + "^ldo-vsram-(others)-sshub$":

Ditto.

> + type: object
> + $ref: regulator.yaml#
> + unevaluatedProperties: false
[..]
> + "^ldo-vsim[2]$":

Based on the example, should be [12].

Thanks,
Nícolas

> + type: object
[..]
> + mt6366_vsim1_reg: ldo-vsim1 {
> + regulator-enable-ramp-delay = <540>;
> + };
[..]
> + mt6366_vsim2_reg: ldo-vsim2 {
> + regulator-enable-ramp-delay = <540>;
> + };
[..]