Re: [PATCH linux-next] mm/slab_common: Remove the unneeded result variable

[Hyeonggon Yoo]

On Tue, Aug 23, 2022 at 4:52 PM <cgel.zte@xxxxxxxxx> wrote:
>
> From: ye xingchen <ye.xingchen@xxxxxxxxxx>
>
> Return the value from __kmem_cache_shrink() directly instead of storing it
>  in another redundant variable.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: ye xingchen <ye.xingchen@xxxxxxxxxx>
> ---
>  mm/slab_common.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index 17996649cfe3..0dfa3cfb6be5 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -495,13 +495,9 @@ EXPORT_SYMBOL(kmem_cache_destroy);
>   */
>  int kmem_cache_shrink(struct kmem_cache *cachep)
>  {
> -       int ret;
> -
> -
>         kasan_cache_shrink(cachep);
> -       ret = __kmem_cache_shrink(cachep);
>
> -       return ret;
> +       return __kmem_cache_shrink(cachep);
>  }
>  EXPORT_SYMBOL(kmem_cache_shrink);
>

Acked-by: Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx>

> --
> 2.25.1