Re: [PATCH 1/3] dt-bindings: iio: adc: Add docs for LTC2499
From: Jonathan Cameron
Date: Mon Aug 22 2022 - 15:59:19 EST
On Mon, 22 Aug 2022 15:51:04 +0300
Ciprian Regus <ciprian.regus@xxxxxxxxxx> wrote:
> Update the bindings documentation for ltc2497 to include the ltc2499.
>
> Signed-off-by: Ciprian Regus <ciprian.regus@xxxxxxxxxx>
Looks fine to me. Maybe a separate patch to add the ltc2496 binding
given the driver is included in this MAINTAINERS entry?
A random comment inline.
Jonathan
> ---
> Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml | 6 +++++-
> MAINTAINERS | 1 +
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> index c1772b568cd1..7bb30eafc543 100644
> --- a/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> @@ -13,10 +13,14 @@ description: |
> 16bit ADC supporting up to 16 single ended or 8 differential inputs.
> I2C interface.
>
> + https://www.analog.com/media/en/technical-documentation/data-sheets/2497fb.pdf
> + https://www.analog.com/media/en/technical-documentation/data-sheets/2499fe.pdf
> +
> properties:
> compatible:
> - const:
> + enum:
> lltc,ltc2497
> + lltc,ltc2499
>
> reg: true
> vref-supply: true
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9d7f64dc0efe..3c847619ceb1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1327,6 +1327,7 @@ W: https://ez.analog.com/linux-software-drivers
> F: Documentation/ABI/testing/sysfs-bus-iio-frequency-ad9523
> F: Documentation/ABI/testing/sysfs-bus-iio-frequency-adf4350
> F: Documentation/devicetree/bindings/iio/*/adi,*
> +F: Documentation/devicetree/bindings/iio/adc/lltc,ltc2497.yaml
> F: Documentation/devicetree/bindings/iio/dac/adi,ad5758.yaml
Unrelated question, but why is this here given the wild cards above match?
> F: drivers/iio/*/ad*
> F: drivers/iio/adc/ltc249*