Re: [PATCH 1/4] dt-bindings: soc: qcom: Introduce PMIC GLINK binding

From: Rob Herring
Date: Mon Aug 22 2022 - 08:40:38 EST


On Wed, Aug 17, 2022 at 08:15:09PM -0700, Bjorn Andersson wrote:
> The PMIC GLINK service, running on a coprocessor on some modern Qualcomm
> platforms and implement USB Type-C handling and battery management.
> This binding describes the component in the OS used to communicate with
> the firmware and connect it's resources to those described in the
> Devicetree, particularly the USB Type-C controllers relationship with
> USB and DisplayPort components.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> ---
> .../bindings/soc/qcom/qcom,pmic-glink.yaml | 98 +++++++++++++++++++
> 1 file changed, 98 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> new file mode 100644
> index 000000000000..3261f9d27a47
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> @@ -0,0 +1,98 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/qcom/qcom,pmic-glink.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm PMIC GLINK firmware interface for battery management, USB
> + Type-C and other things.
> +
> +maintainers:
> + - Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> +
> +description:
> + The PMIC GLINK service, running on a coprocessor on some modern Qualcomm
> + platforms and implement USB Type-C handling and battery management. This
> + binding describes the component in the OS used to communicate with the
> + firmware and connect it's resources to those described in the Devicetree,
> + particularly the USB Type-C controllers relationship with USB and DisplayPort
> + components.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - qcom,sc8180x-pmic-glink
> + - qcom,sc8280xp-pmic-glink
> + - qcom,sm8350-pmic-glink
> + - const: qcom,pmic-glink
> +
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
> +patternProperties:
> + '^connector@\d$':
> + $ref: /schemas/connector/usb-connector.yaml#
> + unevaluatedProperties: false
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
> +
> +examples:
> + - |+
> + pmic-glink {
> + compatible = "qcom,sc8280xp-pmic-glink", "qcom,pmic-glink";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + connector@0 {
> + compatible = "usb-c-connector";
> + reg = <0>;

'reg' causes a warning:

Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.example.dtb: pmic-glink: connector@0: Unevaluated properties are not allowed ('reg' was unexpected)

> + power-role = "dual";
> + data-role = "dual";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + endpoint {
> + remote-endpoint = <&usb_role>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + endpoint@0 {
> + reg = <0>;
> + remote-endpoint = <&qmp_out>;
> + };
> +
> + endpoint@1 {
> + reg = <1>;
> + remote-endpoint = <&displayport_hpd>;
> + };
> + };
> +
> + port@2 {
> + reg = <2>;
> + endpoint {
> + remote-endpoint = <&sbu_mux>;
> + };
> + };
> + };
> + };
> + };
> +...
> +
> --
> 2.35.1
>
>