Re: [RFC][PATCHES] termios.h cleanups

[Linus Torvalds]

On Sat, Aug 20, 2022 at 11:44 AM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
>         Umm...  Might as well, I guess...  Where to put those, though?
> drivers/tty/tty_ioctl.c is not an option, unfortunately - it'll pick
> the local definitions, __weak or no __weak.

IThat bug is ancient history, and tty_ioctl.c is just fine.

Yes, we used to have the "you can't have __weak function definitions
in the same file that uses them" rule.

But it was due to a bug in gcc-4.1, which would inline weak functions.

But we long since gave up on gcc-4.1, and we have __weak functions
declarations in the same file as the use in multiple places. See for
example arch_release_task_struct() in kernel/fork.c.

                 Linus