Re: [PATCH 5.15 089/779] md-raid10: fix KASAN warning

[Mikulas Patocka]

On Fri, 19 Aug 2022, Pavel Machek wrote:

> Hi!
> 
> > From: Mikulas Patocka <mpatocka@xxxxxxxxxx>
> > 
> > commit d17f744e883b2f8d13cca252d71cfe8ace346f7d upstream.
> > 
> > There's a KASAN warning in raid10_remove_disk when running the lvm
> > test lvconvert-raid-reshape.sh. We fix this warning by verifying that the
> > value "number" is valid.
> > 
> > BUG: KASAN: slab-out-of-bounds in raid10_remove_disk+0x61/0x2a0 [raid10]
> > Read of size 8 at addr ffff889108f3d300 by task mdX_raid10/124682
> 
> Is this place for array_index_nospec?
> 
> Best regards,
> 								Pavel

Hi

I think it is not needed - userspace code can't trigger this code path at 
will.

Mikulas