Re: [PATCH] KVM: x86: Fix mce_banks memory leak on mci_ctl2_banks allocation failure

From: Jim Mattson
Date: Fri Aug 19 2022 - 17:54:57 EST


On Fri, Aug 19, 2022 at 11:23 AM Vipin Sharma <vipinsh@xxxxxxxxxx> wrote:
>
> If mci_ctl2_banks allocation fails, kvm goes to fail_free_pio_data and
> forgets about freeing mce_banks memory causing memory leak.
>
> Individually check memory allocation status and free memory in the correct
> order.
>
> Fixes: 281b52780b57 ("KVM: x86: Add emulation for MSR_IA32_MCx_CTL2 MSRs.")
> Signed-off-by: Vipin Sharma <vipinsh@xxxxxxxxxx>
> ---
Reviewed-by: Jim Mattson <jmattson@xxxxxxxxxx>