Re: [PATCH] netfilter: move from strlcpy with unused retval to strscpy

From: Simon Horman
Date: Fri Aug 19 2022 - 05:50:15 EST


On Thu, Aug 18, 2022 at 11:02:24PM +0200, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@xxxxxxxxxxxxxx/
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Thanks Wolfram,

FWIIW, for the IPVS portion:

Reviewed-by: Simon Horman <horms@xxxxxxxxxxxx>

> ---
> net/netfilter/ipset/ip_set_core.c | 4 ++--
> net/netfilter/ipvs/ip_vs_ctl.c | 8 ++++----
> net/netfilter/nf_log.c | 4 ++--
> net/netfilter/nf_tables_api.c | 2 +-
> net/netfilter/nft_osf.c | 2 +-
> net/netfilter/x_tables.c | 20 ++++++++++----------
> net/netfilter/xt_RATEEST.c | 2 +-
> 7 files changed, 21 insertions(+), 21 deletions(-)

...