Re: [PATCH 1/2] dt-bindings: leds: register-bit-led: Add active-low property

From: Krzysztof Kozlowski
Date: Fri Aug 19 2022 - 02:47:06 EST


On 18/08/2022 20:25, Pali Rohár wrote:
> Allow to define inverted logic (0 - enable LED, 1 - disable LED) via
> active-low property.
>
> Signed-off-by: Pali Rohár <pali@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/leds/register-bit-led.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/register-bit-led.yaml b/Documentation/devicetree/bindings/leds/register-bit-led.yaml
> index 79b8fc0f9d23..5c6ef26f1a94 100644
> --- a/Documentation/devicetree/bindings/leds/register-bit-led.yaml
> +++ b/Documentation/devicetree/bindings/leds/register-bit-led.yaml
> @@ -43,6 +43,11 @@ properties:
> 0x100000, 0x200000, 0x400000, 0x800000, 0x1000000, 0x2000000, 0x4000000,
> 0x8000000, 0x10000000, 0x20000000, 0x40000000, 0x80000000 ]
>
> + active-low:
> + $ref: /schemas/types.yaml#/definitions/flag

This could be shorter: type: boolean

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Although the question is - where is the user of it?

Best regards,
Krzysztof