Re: [PATCH net-next] net: sched: remove duplicate check of user rights in qdisc

From: shaozhengchao
Date: Fri Aug 19 2022 - 00:21:25 EST




On 2022/8/19 11:44, Jakub Kicinski wrote:
On Thu, 18 Aug 2022 15:25:00 +0800 Zhengchao Shao wrote:
- if ((n->nlmsg_type != RTM_GETACTION) &&
- !netlink_capable(skb, CAP_NET_ADMIN))
- return -EPERM;

This check is not network namespace capable, right?

We're probably fine making it namespace aware but it needs to be a
separate change.

Hi Jakub:
Thank you for your reply. I will add the wrong deletion back in V2. And I will also consider to make checking namespace aware in action function.

Zhengchao Shao