Re: [PATCH v2 2/2] mm/damon: replace pmd_huge() with pmd_trans_huge() for THP

From: SeongJae Park
Date: Thu Aug 18 2022 - 12:48:25 EST


Hi Baolin,

On Thu, 18 Aug 2022 15:37:44 +0800 Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx> wrote:

> The pmd_huge() is usually used to indicate if a pmd level hugetlb,
> however a pmd mapped huge page can only be THP in damon_mkold_pmd_entry()
> or damon_young_pmd_entry(), so replacing pmd_huge() with pmd_trans_huge()
> in this case to make code more readable according to the discussion [1].

Thanks to Baolin and Muchun for the discussion and this patch!

>
> [1] https://lore.kernel.org/all/098c1480-416d-bca9-cedb-ca495df69b64@xxxxxxxxxxxxxxxxx/
>
> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>

Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>


Thanks,
SJ

[...]