Re: stalling IO regression since linux 5.12, through 5.18
From: Ming Lei
Date: Thu Aug 18 2022 - 11:10:48 EST
On Thu, Aug 18, 2022 at 9:50 PM Chris Murphy <lists@xxxxxxxxxxxxxxxxx> wrote:
>
>
>
> On Thu, Aug 18, 2022, at 1:24 AM, Ming Lei wrote:
>
> >
> > Also please test the following one too:
> >
> >
> > diff --git a/block/blk-mq.c b/block/blk-mq.c
> > index 5ee62b95f3e5..d01c64be08e2 100644
> > --- a/block/blk-mq.c
> > +++ b/block/blk-mq.c
> > @@ -1991,7 +1991,8 @@ bool blk_mq_dispatch_rq_list(struct blk_mq_hw_ctx
> > *hctx, struct list_head *list,
> > if (!needs_restart ||
> > (no_tag && list_empty_careful(&hctx->dispatch_wait.entry)))
> > blk_mq_run_hw_queue(hctx, true);
> > - else if (needs_restart && needs_resource)
> > + else if (needs_restart && (needs_resource ||
> > + blk_mq_is_shared_tags(hctx->flags)))
> > blk_mq_delay_run_hw_queue(hctx, BLK_MQ_RESOURCE_DELAY);
> >
> > blk_mq_update_dispatch_busy(hctx, true);
> >
>
> Should I test both patches at the same time, or separately? On top of v5.17 clean, or with b6e68ee82585 still reverted?
Please test it separately against v5.17.
thanks,