Re: [RFT PATCH v2 10/14] arm64: dts: qcom: sdm845: split TCSR halt regs out of mutex

From: Konrad Dybcio
Date: Wed Aug 17 2022 - 17:04:04 EST




On 17.08.2022 15:03, Krzysztof Kozlowski wrote:
> The TCSR halt regs are next to TCSR mutex, so before converting the TCSR
> mutex into device with address space, we need to split the halt regs to
> its own syscon device. This also describes more accurately the devices
> and their IO address space.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Not tested on a device, but looks good to the eye:
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>

Konrad
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index f0e286715d1b..21ed14200986 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -2590,7 +2590,12 @@ ipa: ipa@1e40000 {
>
> tcsr_mutex_regs: syscon@1f40000 {
> compatible = "syscon";
> - reg = <0 0x01f40000 0 0x40000>;
> + reg = <0 0x01f40000 0 0x20000>;
> + };
> +
> + tcsr_regs_1: sycon@1f60000 {
> + compatible = "qcom,sdm845-tcsr", "syscon";
> + reg = <0 0x01f60000 0 0x20000>;
> };
>
> tlmm: pinctrl@3400000 {
> @@ -3207,7 +3212,7 @@ mss_pil: remoteproc@4080000 {
> <&pdc_reset PDC_MODEM_SYNC_RESET>;
> reset-names = "mss_restart", "pdc_reset";
>
> - qcom,halt-regs = <&tcsr_mutex_regs 0x23000 0x25000 0x24000>;
> + qcom,halt-regs = <&tcsr_regs_1 0x3000 0x5000 0x4000>;
>
> power-domains = <&rpmhpd SDM845_CX>,
> <&rpmhpd SDM845_MX>,