Re: [PATCH v9 23/27] Kbuild: add Rust support

From: Miguel Ojeda
Date: Wed Aug 17 2022 - 16:56:40 EST


On Wed, Aug 17, 2022 at 10:26 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> It'd be nice to split this up into maybe per-target patches, but given
> how long this has been getting developed, I'd prefer to avoid blocking
> on that, and just get this series landed so we can move to incremental
> fixes/additions.

When I started the series, I considered several approaches, and in the
end opted for "setup as much as possible before the flag-patch that
enables the Kbuild support", which was simple, though indeed the
Kbuild patch remained fairly big.

Then some people commented on that patch over several versions, so I
kept the simple strategy :)

What I can look into is moving the optional targets out of this patch,
putting them after the "flag-patch", since they may be considered
"additional features" anyway. In fact, for the trimming down in v9, I
thought about removing them entirely. It will not change things too
much, since they are small, but it may help.

For v9 I nevertheless attempted to simplify this patch by doing the
"move all new, big files to their own patch" (see my reply at [1]), so
it is fairly smaller than in previous versions.

[1] https://lore.kernel.org/lkml/CANiq72nzOQSd2vsh2_=0YpGNpY=7agokbgi_vBc5_GF4-02rsA@xxxxxxxxxxxxxx/

Cheers,
Miguel