Re: [PATCH] scripts/Makefile.extrawarn: Do not disable clang's -Wformat-zero-length

From: Masahiro Yamada
Date: Wed Aug 17 2022 - 10:46:13 EST


On Thu, Aug 11, 2022 at 8:01 AM Nathan Chancellor <nathan@xxxxxxxxxx> wrote:
>
> There are no instances of this warning in the tree across several
> difference architectures and configurations. This was added by
> commit 26ea6bb1fef0 ("kbuild, LLVMLinux: Supress warnings unless W=1-3")
> back in 2014, where it might have been necessary, but there are no
> instances of it now so stop disabling it to increase warning coverage
> for clang.
>
> Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> ---

Applied to linux-kbuild/fixes. Thanks.



> scripts/Makefile.extrawarn | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
> index 9bbaf7112a9b..69cec45c4e71 100644
> --- a/scripts/Makefile.extrawarn
> +++ b/scripts/Makefile.extrawarn
> @@ -48,7 +48,6 @@ else
> ifdef CONFIG_CC_IS_CLANG
> KBUILD_CFLAGS += -Wno-initializer-overrides
> KBUILD_CFLAGS += -Wno-sign-compare
> -KBUILD_CFLAGS += -Wno-format-zero-length
> KBUILD_CFLAGS += $(call cc-disable-warning, pointer-to-enum-cast)
> KBUILD_CFLAGS += -Wno-tautological-constant-out-of-range-compare
> KBUILD_CFLAGS += $(call cc-disable-warning, unaligned-access)
>
> base-commit: aeb6e6ac18c73ec287b3b1e2c913520699358c13
> --
> 2.37.1
>


--
Best Regards
Masahiro Yamada