Re: [PATCH -next] iommu: return early when devices in a group require different domain type

From: Baolu Lu
Date: Wed Aug 17 2022 - 06:35:03 EST


On 2022/8/16 10:07, Yuan Can wrote:
When alloc default domain for an iommu_group in
probe_alloc_default_domain, the expected domain
type of each device in the iommu_group is checked
in a loop, if two devices require different types,
the loop can be breaked since the default domain
will be set to iommu_def_domain_type.
Return 1 when this happened to break the loop in
__iommu_group_for_each_dev.

Signed-off-by: Yuan Can <yuancan@xxxxxxxxxx>

Nit:
Try to use up the allowed number of characters per line before wrapping
and use "./scripts/checkpatch.pl --strict --codespell _your_patch_file"
to check the patch.

For the change:

Reviewed-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>

Best regards,
baolu

---
drivers/iommu/iommu.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 74bc9111c7be..0d4d78946d31 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -1653,6 +1653,7 @@ static int probe_get_default_domain_type(struct device *dev, void *data)
dev_name(gtype->dev),
iommu_domain_type_str(gtype->type));
gtype->type = 0;
+ return 1; /* end the outer loop */
}
if (!gtype->dev) {