Re: [PATCH v11 13/13] dm: add power-of-2 target for zoned devices with non power-of-2 zone sizes
From: Pankaj Raghav
Date: Wed Aug 17 2022 - 03:36:52 EST
Hi Damien,
>> + */
>> +static bool bio_in_emulated_zone_area(struct dm_po2z_target *dmh,
>> + struct bio *bio, int *offset)
>
> This function name reads like it is a block layer helper. It mat be less
> confucing to keep using the dm_po2z_ prefix for it.
>
Good point. Even though it is a static function in the same file, it could
be confused for a block helper at the caller site.
>> +{
>> + /*
>> + * Read operation on the emulated zone area (between zone capacity
>> + * and zone size) will fill the bio with zeroes. Any other operation
>> +
>> + return DM_MAPIO_KILL;
>> +}
>
Do you see any more issues apart from the two you pointed out?