Re: [PATCH] ASoC: fsl_sai: Remove unnecessary FIFO reset in ISR

From: Nicolin Chen
Date: Wed Aug 17 2022 - 02:21:23 EST


On Tue, Aug 16, 2022 at 10:41 PM Shengjiu Wang <shengjiu.wang@xxxxxxx> wrote:
>
> The FIFO reset drops the words in the FIFO, which may cause
> channel swap when SAI module is running, especially when the
> DMA speed is low. So it is not good to do FIFO reset in ISR,
> then remove the operation.

I don't recall the details of adding this many years ago, but
leaving underrun/overrun errors unhandled does not sound right
to me either. Would it result in a channel swap also? Perhaps
there needs to be a reset routine that stops and restarts the
DMA as well?