Re: [PATCH v2 1/6] Documentation: tps6594x: Add DT bindings for the TPS6594x PMIC

From: Rob Herring
Date: Tue Aug 16 2022 - 13:21:00 EST


On Thu, Aug 11, 2022 at 08:22:37PM -0700, Matt Ranostay wrote:
> Signed-off-by: Matt Ranostay <mranostay@xxxxxx>

Commit message? Use a subject prefix appropriate for the subsystem.

> ---
> .../devicetree/bindings/mfd/ti,tps6594x.yaml | 56 +++++++++++++++++++
> 1 file changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml b/Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml
> new file mode 100644
> index 000000000000..9b5e17f63709
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/ti,tps6594x.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/ti,tps6594x.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TPS6594x Power Management Integrated Circuit (PMIC)
> +
> +maintainers:
> + - Keerthy <j-keerthy@xxxxxx>
> +
> +properties:
> + compatible:
> + contains:

No, this means '"foo", "ti,tps6594x", "bar"' is valid.

> + enum:

Use 'const' if only 1 entry.

> + - ti,tps6594x

Don't use wildcards in compatible strings.

> +
> + reg:
> + const: 0x48
> + description: I2C slave address
> +
> + ti,system-power-controller:
> + type: boolean
> + description: PMIC is controlling the system power.
> +
> + rtc:

Why do you need a sub-node here? Is the RTC a separate block with its
own resources?

> + type: object
> + $ref: /schemas/rtc/rtc.yaml#
> + unevaluatedProperties: false
> + properties:
> + compatible:
> + const: ti,tps6594x-rtc
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + - |
> + i2c0 {

i2c {

> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmic: pmic@48 {
> + compatible = "ti,tps6594x";
> + reg = <0x48>;
> +
> + rtc {
> + compatible = "ti,tps6594x-rtc";
> + };
> + };
> + };
> +
> +...
> --
> 2.36.1
>
>