RE: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver bindings

[Shenwei Wang]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Thursday, August 11, 2022 9:36 AM
> To: Shenwei Wang <shenwei.wang@xxxxxxx>; robh+dt@xxxxxxxxxx;
> krzysztof.kozlowski+dt@xxxxxxxxxx; linus.walleij@xxxxxxxxxx; brgl@xxxxxxxx;
> shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> festevam@xxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> gpio@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; imx@xxxxxxxxxxxxxxx
> Subject: [EXT] Re: [PATCH v4 1/3] dt-bindings: gpio: Add imx scu gpio driver
> bindings
> > diff --git
> > a/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml
> > b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml
> > new file mode 100644
> > index 000000000000..a1b024cddc97
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/gpio/fsl,imx-sc-gpio.yaml
> > +description: |
> > +  This module provides the standard interface to control the
> > +  resource pins in SCU domain on i.MX8 platforms.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - fsl,imx8qxp-sc-gpio
> 
> Now the filename does not match compatible. Use the same compatible as
> filename.

The subnodes under fsl,scu.yaml have their own naming rule. For example, the watchdog
compatible is "fsl,imx-sc-wdt", but the file name is "fsl,scu-wdt.yaml". Is the filename required 
to match its compatible?

Regards,
Shenwei

> 
> Best regards,
> Krzysztof