Re: [PATCH v1 2/2] PCI: dwc: add support for 64-bit MSI target address

From: Christoph Hellwig
Date: Thu Aug 11 2022 - 05:22:33 EST


On Tue, Aug 09, 2022 at 06:00:50PM +0000, Will McVicker wrote:
> + bool msi_64b = false;

Spellt out bit here?

> + msi_capabilities = dw_pcie_msi_capabilities(pci);
> + if (msi_capabilities & PCI_MSI_FLAGS_ENABLE)
> + msi_64b = msi_capabilities & PCI_MSI_FLAGS_64BIT ? true : false;

No need for the tenary operator here:

msi_64bit = msi_capabilities & PCI_MSI_FLAGS_64BIT;