Re: [PATCH v4 08/17] perf pmu-events: Hide pmu_sys_event_tables

From: Ian Rogers
Date: Wed Aug 10 2022 - 10:26:16 EST


On Fri, Aug 5, 2022 at 4:15 AM John Garry <john.garry@xxxxxxxxxx> wrote:
>
> On 04/08/2022 23:18, Ian Rogers wrote:
> > Move usage of the table to pmu-events.c so it may be hidden. By
> > abstracting the table the implementation can later be changed.
> >
> > Signed-off-by: Ian Rogers<irogers@xxxxxxxxxx>
>
> Reviewed-by: John Garry <john.garry@xxxxxxxxxx>
>
> > - const struct pmu_event *sys_event_tables = __test_pmu_get_sys_events_table();
> > + const struct pmu_event *sys_event_tables = find_sys_events_table("pme_test_soc_sys");
>
> Maybe we can change to not need the "pme_" prefix or even some of the
> suffix, like "_sys"

Ack. Not done here so the change is the smallest possible.

Thanks,
Ian

> > const struct pmu_events_map *map = __test_pmu_get_events_map();
>