[chao:feature/dax 1/10] fs/f2fs/super.c:1635:2: error: call to undeclared function 'fs_put_dax'; ISO C99 and later do not support implicit function declarations
From: kernel test robot
Date: Sun Aug 07 2022 - 14:15:58 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git feature/dax
head: 42f73c9b2a369f724de6c1df5acb0bbde2688e35
commit: 7df0eb556b0ee20e66872600b62542a7f39d444c [1/10] f2fs: support iomap operation
config: x86_64-randconfig-a012 (https://download.01.org/0day-ci/archive/20220808/202208080245.IQxuEwkr-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 5f1c7e2cc5a3c07cbc2412e851a7283c1841f520)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git/commit/?id=7df0eb556b0ee20e66872600b62542a7f39d444c
git remote add chao https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git
git fetch --no-tags chao feature/dax
git checkout 7df0eb556b0ee20e66872600b62542a7f39d444c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/f2fs/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
>> fs/f2fs/super.c:1635:2: error: call to undeclared function 'fs_put_dax'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
fs_put_dax(sbi->s_daxdev);
^
>> fs/f2fs/super.c:4037:18: error: call to undeclared function 'fs_dax_get_by_bdev'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
sbi->s_daxdev = fs_dax_get_by_bdev(sb->s_bdev, &sbi->s_dax_part_off);
^
fs/f2fs/super.c:4037:18: note: did you mean 'blkdev_get_by_dev'?
include/linux/blkdev.h:1520:22: note: 'blkdev_get_by_dev' declared here
struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder);
^
>> fs/f2fs/super.c:4037:16: error: incompatible integer to pointer conversion assigning to 'struct dax_device *' from 'int' [-Wint-conversion]
sbi->s_daxdev = fs_dax_get_by_bdev(sb->s_bdev, &sbi->s_dax_part_off);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fs/f2fs/super.c:4492:2: error: call to undeclared function 'fs_put_dax'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
fs_put_dax(sbi->s_daxdev);
^
4 errors generated.
vim +/fs_put_dax +1635 fs/f2fs/super.c
1531
1532 static void f2fs_put_super(struct super_block *sb)
1533 {
1534 struct f2fs_sb_info *sbi = F2FS_SB(sb);
1535 int i;
1536 bool dropped;
1537
1538 /* unregister procfs/sysfs entries in advance to avoid race case */
1539 f2fs_unregister_sysfs(sbi);
1540
1541 f2fs_quota_off_umount(sb);
1542
1543 /* prevent remaining shrinker jobs */
1544 mutex_lock(&sbi->umount_mutex);
1545
1546 /*
1547 * flush all issued checkpoints and stop checkpoint issue thread.
1548 * after then, all checkpoints should be done by each process context.
1549 */
1550 f2fs_stop_ckpt_thread(sbi);
1551
1552 /*
1553 * We don't need to do checkpoint when superblock is clean.
1554 * But, the previous checkpoint was not done by umount, it needs to do
1555 * clean checkpoint again.
1556 */
1557 if ((is_sbi_flag_set(sbi, SBI_IS_DIRTY) ||
1558 !is_set_ckpt_flags(sbi, CP_UMOUNT_FLAG))) {
1559 struct cp_control cpc = {
1560 .reason = CP_UMOUNT,
1561 };
1562 f2fs_write_checkpoint(sbi, &cpc);
1563 }
1564
1565 /* be sure to wait for any on-going discard commands */
1566 dropped = f2fs_issue_discard_timeout(sbi);
1567
1568 if ((f2fs_hw_support_discard(sbi) || f2fs_hw_should_discard(sbi)) &&
1569 !sbi->discard_blks && !dropped) {
1570 struct cp_control cpc = {
1571 .reason = CP_UMOUNT | CP_TRIMMED,
1572 };
1573 f2fs_write_checkpoint(sbi, &cpc);
1574 }
1575
1576 /*
1577 * normally superblock is clean, so we need to release this.
1578 * In addition, EIO will skip do checkpoint, we need this as well.
1579 */
1580 f2fs_release_ino_entry(sbi, true);
1581
1582 f2fs_leave_shrinker(sbi);
1583 mutex_unlock(&sbi->umount_mutex);
1584
1585 /* our cp_error case, we can wait for any writeback page */
1586 f2fs_flush_merged_writes(sbi);
1587
1588 f2fs_wait_on_all_pages(sbi, F2FS_WB_CP_DATA);
1589
1590 f2fs_bug_on(sbi, sbi->fsync_node_num);
1591
1592 f2fs_destroy_compress_inode(sbi);
1593
1594 iput(sbi->node_inode);
1595 sbi->node_inode = NULL;
1596
1597 iput(sbi->meta_inode);
1598 sbi->meta_inode = NULL;
1599
1600 /*
1601 * iput() can update stat information, if f2fs_write_checkpoint()
1602 * above failed with error.
1603 */
1604 f2fs_destroy_stats(sbi);
1605
1606 /* destroy f2fs internal modules */
1607 f2fs_destroy_node_manager(sbi);
1608 f2fs_destroy_segment_manager(sbi);
1609
1610 f2fs_destroy_post_read_wq(sbi);
1611
1612 kvfree(sbi->ckpt);
1613
1614 sb->s_fs_info = NULL;
1615 if (sbi->s_chksum_driver)
1616 crypto_free_shash(sbi->s_chksum_driver);
1617 kfree(sbi->raw_super);
1618
1619 destroy_device_list(sbi);
1620 f2fs_destroy_page_array_cache(sbi);
1621 f2fs_destroy_xattr_caches(sbi);
1622 mempool_destroy(sbi->write_io_dummy);
1623 #ifdef CONFIG_QUOTA
1624 for (i = 0; i < MAXQUOTAS; i++)
1625 kfree(F2FS_OPTION(sbi).s_qf_names[i]);
1626 #endif
1627 fscrypt_free_dummy_policy(&F2FS_OPTION(sbi).dummy_enc_policy);
1628 destroy_percpu_info(sbi);
1629 f2fs_destroy_iostat(sbi);
1630 for (i = 0; i < NR_PAGE_TYPE; i++)
1631 kvfree(sbi->write_io[i]);
1632 #if IS_ENABLED(CONFIG_UNICODE)
1633 utf8_unload(sb->s_encoding);
1634 #endif
> 1635 fs_put_dax(sbi->s_daxdev);
1636 kfree(sbi);
1637 }
1638
--
0-DAY CI Kernel Test Service
https://01.org/lkp