Re: [PATCH v2] x86/bugs: Enable STIBP for IBPB mitigated RetBleed

From: Ingo Molnar
Date: Sat Aug 06 2022 - 15:01:03 EST



* Kim Phillips <kim.phillips@xxxxxxx> wrote:

> Speculative Code Execution with Return Instructions)
> vulnerability.
>
> + AMD-based unret and ibpb mitigations alone do not stop
> + sibling threads influencing the predictions of other sibling
> + threads. For that reason, we use STIBP on processors
> + that support it, and mitigate SMT on processors that don't.

> * retbleed_select_mitigation(); specifically the STIBP selection is
> - * forced for UNRET.
> + * forced for UNRET or IBPB.

Nit: could you please capitalize the acronyms & instruction names
consistently? Human eyesight is case sensitive.

Ie. it should be UNRET and IBPB everywhere.

Thanks,

Ingo