Re: [PATCH 0/4] drm/udl: Fix stray URBs and cleanup

[Thomas Zimmermann]

Hi Takashi,

Am 04.08.22 um 09:58 schrieb Takashi Iwai:
> Hi,
>
> this is a series of fixes for UDL driver to address the leftover URBs
> at suspend/resume.  It begins with the simplification of FIFO control
> code with the standard wait queue, followed by the handling of pending
> URBs, and replace BUG_ON() with WARN_ON() as a cleanup.

Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx>

That's a lot better than what's currently there. If no other reviews 
come in, I'll add the patches next week.

Best regards
Thomas

> Takashi
>
> ===
>
> Takashi Iwai (4):
>    drm/udl: Replace semaphore with a simple wait queue
>    drm/udl: Sync pending URBs at suspend / disconnect
>    drm/udl: Kill pending URBs at suspend and disconnect
>    drm/udl: Replace BUG_ON() with WARN_ON()
>
>   drivers/gpu/drm/udl/udl_drv.h      |  14 +++-
>   drivers/gpu/drm/udl/udl_main.c     | 125 ++++++++++++++---------------
>   drivers/gpu/drm/udl/udl_modeset.c  |   4 +
>   drivers/gpu/drm/udl/udl_transfer.c |   3 +-
>   4 files changed, 79 insertions(+), 67 deletions(-)

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Attachment: OpenPGP_signature
Description: OpenPGP digital signature