Re: [PATCH v4] net: fix refcount bug in sk_psock_get (2)

From: Hawkins Jiawei
Date: Fri Aug 05 2022 - 02:29:33 EST


On Thu, 4 Aug 2022 at 23:29, Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Thu, 4 Aug 2022 11:05:15 +0800 Hawkins Jiawei wrote:
> > I wonder if it is proper to gather these together in a patchset, for
> > they are all about flags in sk_user_data, maybe:
> >
> > [PATCH v5 0/2] net: enhancement to flags in sk_user_data field
> > - introduce the patchset
> >
> > [PATCH v5 1/2] net: clean up code for flags in sk_user_data field
> > - refactor the things in include/linux/skmsg.h and
> > include/net/sock.h
> > - refactor the flags's usage by other code, such as
> > net/core/skmsg.c and kernel/bpf/reuseport_array.c
> >
> > [PATCH v5 2/2] net: fix refcount bug in sk_psock_get (2)
> > - add SK_USER_DATA_PSOCK flag in sk_user_data field
>
> Usually the fix comes first, because it needs to be backported to
> stable, and we don't want to have to pull extra commits into stable
> and risk regressions in code which was not directly involved in the bug.
Ok, I got it. Thanks for the explanation.