Re: [PATCH] staging: r8188eu: convert rtw_p2p_enable to correct error code semantics

[Phillip Potter]

On Thu, Aug 04, 2022 at 10:26:39PM +0200, Philipp Hortmann wrote:
> On 8/3/22 01:44, Phillip Potter wrote:
> > Convert the rtw_p2p_enable function to use correct error code semantics
> > rather than _SUCCESS/_FAIL, and also make sure we allow these to be
> > passed through properly in the one caller where we actually check the
> > code, rtw_wext_p2p_enable.
> > 
> > This change moves these functions to a clearer 'return 0;' style at the
> > end of the function, and in the case of errors now returns ret instead
> > of jumping to the end of the function, so that these can still be passed
> > through but without using a goto to jump to a single return statement at
> > the end which is less clear.
> > 
> > This change moves the driver slowly closer to using standard error code
> > semantics everywhere.
> > 
> > Signed-off-by: Phillip Potter<phil@xxxxxxxxxxxxxxxx>
> > ---
> >   drivers/staging/r8188eu/core/rtw_p2p.c       | 19 ++++++++-----------
> >   drivers/staging/r8188eu/os_dep/ioctl_linux.c | 12 +++++-------
> >   2 files changed, 13 insertions(+), 18 deletions(-)
> 
> 
> Tested-by: Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx> # Edimax N150

Thank you for testing Philipp :-)

Regards,
Phil