Re: [RFC FIX PATCH] x86/e820: Stop kernel boot when RAM resource reservation fails

From: Ingo Molnar
Date: Thu Aug 04 2022 - 05:46:44 EST



* Bharata B Rao <bharata@xxxxxxx> wrote:

> On 7/18/2022 8:37 PM, Borislav Petkov wrote:
> >
> > I betcha you can generate a lot of "kernel bugs" with weird qemu
> > options. If it is not a real use case, nobody cares.
>
> I see that we will hit this problem by default when starting
> a guest with 1T or more memory using QEMU.
>
> >
> > And even if it were a real use case, panicking the machine is not the
> > right fix.
>
> I couldn't see a clean exit/recovery option in
> setup_arch()->e820__reserve_resources() where this happens. Any
> suggestions?

I'd emit a low impact, non-fatal WARN()ing to make sure users aren't silent
victims of an easily detectable firmware (Qemu) misconfiguration.

Thanks,

Ingo