[kuba:dpll-changes 2062/2068] drivers/ptp/ptp_ocp.c:3743:21: warning: assignment discards 'const' qualifier from pointer target type

From: kernel test robot
Date: Wed Aug 03 2022 - 11:16:20 EST

Next message: James Hilliard: "Re: [PATCH] libbpf: ensure functions with always_inline attribute are inline"
Previous message: Benson Leung: "Re: [PATCH] Supporting wake on DP hot events behind TBT/USB4 routers"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

tree: https://git.kernel.org/pub/scm/linux/kernel/git/kuba/linux.git dpll-changes
head: 9fe25d755c104116a844f268fb6bae41569e28fb
commit: 48c4cd1d7a94aeb6ab460989f1561117291092a5 [2062/2068] ptp_ocp: implement DPLL ops
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220803/202208032332.nb8chyJc-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/kuba/linux.git/commit/?id=48c4cd1d7a94aeb6ab460989f1561117291092a5
git remote add kuba https://git.kernel.org/pub/scm/linux/kernel/git/kuba/linux.git
git fetch --no-tags kuba dpll-changes
git checkout 48c4cd1d7a94aeb6ab460989f1561117291092a5
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/dpll/ drivers/ptp/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

drivers/dpll/dpll_netlink.c: In function 'dpll_genl_cmd_set_source':
drivers/dpll/dpll_netlink.c:227:39: error: initialization of 'const struct nlattr **' from incompatible pointer type 'struct nlattr **' [-Werror=incompatible-pointer-types]
227 | const struct nlattr **attrs = p->attrs;
| ^
drivers/dpll/dpll_netlink.c: In function 'dpll_genl_cmd_set_output':
drivers/dpll/dpll_netlink.c:252:39: error: initialization of 'const struct nlattr **' from incompatible pointer type 'struct nlattr **' [-Werror=incompatible-pointer-types]
252 | const struct nlattr **attrs = p->attrs;
| ^
drivers/dpll/dpll_netlink.c: At top level:
>> drivers/dpll/dpll_netlink.c:600:13: warning: no previous prototype for 'dpll_netlink_fini' [-Wmissing-prototypes]
600 | void __exit dpll_netlink_fini(void)
| ^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
drivers/ptp/ptp_ocp.c: In function 'ptp_ocp_dpll_get_status':
drivers/ptp/ptp_ocp.c:3721:48: error: implicit declaration of function 'dpll_priv' [-Werror=implicit-function-declaration]
3721 | struct ptp_ocp *bp = (struct ptp_ocp *)dpll_priv(dpll);
| ^~~~~~~~~
drivers/ptp/ptp_ocp.c: In function 'ptp_ocp_sma_get_dpll_type':
>> drivers/ptp/ptp_ocp.c:3743:21: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
3743 | tbl = bp->sma_op->tbl[0];
| ^
drivers/ptp/ptp_ocp.c:3745:21: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
3745 | tbl = bp->sma_op->tbl[1];
| ^
drivers/ptp/ptp_ocp.c: In function 'ptp_ocp_dpll_type_supported':
>> drivers/ptp/ptp_ocp.c:3754:36: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
3754 | struct ocp_selector *tbl = bp->sma_op->tbl[dir];
| ^~
drivers/ptp/ptp_ocp.c: At top level:
drivers/ptp/ptp_ocp.c:3794:15: error: variable 'dpll_ops' has initializer but incomplete type
3794 | static struct dpll_device_ops dpll_ops = {
| ^~~~~~~~~~~~~~~
drivers/ptp/ptp_ocp.c:3795:10: error: 'struct dpll_device_ops' has no member named 'get_status'
3795 | .get_status = ptp_ocp_dpll_get_status,
| ^~~~~~~~~~
>> drivers/ptp/ptp_ocp.c:3795:35: warning: excess elements in struct initializer
3795 | .get_status = ptp_ocp_dpll_get_status,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/ptp/ptp_ocp.c:3795:35: note: (near initialization for 'dpll_ops')
drivers/ptp/ptp_ocp.c:3796:10: error: 'struct dpll_device_ops' has no member named 'get_lock_status'
3796 | .get_lock_status = ptp_ocp_dpll_get_lock_status,
| ^~~~~~~~~~~~~~~
drivers/ptp/ptp_ocp.c:3796:35: warning: excess elements in struct initializer
3796 | .get_lock_status = ptp_ocp_dpll_get_lock_status,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/ptp/ptp_ocp.c:3796:35: note: (near initialization for 'dpll_ops')
drivers/ptp/ptp_ocp.c:3797:10: error: 'struct dpll_device_ops' has no member named 'get_source_type'
3797 | .get_source_type = ptp_ocp_dpll_get_source_type,
| ^~~~~~~~~~~~~~~
drivers/ptp/ptp_ocp.c:3797:35: warning: excess elements in struct initializer
3797 | .get_source_type = ptp_ocp_dpll_get_source_type,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/ptp/ptp_ocp.c:3797:35: note: (near initialization for 'dpll_ops')
drivers/ptp/ptp_ocp.c:3798:10: error: 'struct dpll_device_ops' has no member named 'get_source_supported'
3798 | .get_source_supported = ptp_ocp_dpll_get_source_supported,
| ^~~~~~~~~~~~~~~~~~~~
drivers/ptp/ptp_ocp.c:3798:35: warning: excess elements in struct initializer
3798 | .get_source_supported = ptp_ocp_dpll_get_source_supported,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/ptp/ptp_ocp.c:3798:35: note: (near initialization for 'dpll_ops')
drivers/ptp/ptp_ocp.c:3799:10: error: 'struct dpll_device_ops' has no member named 'get_output_type'
3799 | .get_output_type = ptp_ocp_dpll_get_output_type,
| ^~~~~~~~~~~~~~~
drivers/ptp/ptp_ocp.c:3799:35: warning: excess elements in struct initializer
3799 | .get_output_type = ptp_ocp_dpll_get_output_type,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/ptp/ptp_ocp.c:3799:35: note: (near initialization for 'dpll_ops')
drivers/ptp/ptp_ocp.c:3800:10: error: 'struct dpll_device_ops' has no member named 'get_output_supported'
3800 | .get_output_supported = ptp_ocp_dpll_get_output_supported,
| ^~~~~~~~~~~~~~~~~~~~
drivers/ptp/ptp_ocp.c:3800:35: warning: excess elements in struct initializer
3800 | .get_output_supported = ptp_ocp_dpll_get_output_supported,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/ptp/ptp_ocp.c:3800:35: note: (near initialization for 'dpll_ops')
drivers/ptp/ptp_ocp.c: In function 'ptp_ocp_probe':
drivers/ptp/ptp_ocp.c:3859:20: error: implicit declaration of function 'dpll_device_alloc'; did you mean 'acpi_spi_device_alloc'? [-Werror=implicit-function-declaration]
3859 | bp->dpll = dpll_device_alloc(&dpll_ops, ARRAY_SIZE(bp->sma), ARRAY_SIZE(bp->sma), bp);
| ^~~~~~~~~~~~~~~~~
| acpi_spi_device_alloc
>> drivers/ptp/ptp_ocp.c:3859:18: warning: assignment to 'struct dpll_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
3859 | bp->dpll = dpll_device_alloc(&dpll_ops, ARRAY_SIZE(bp->sma), ARRAY_SIZE(bp->sma), bp);
| ^
drivers/ptp/ptp_ocp.c:3864:9: error: implicit declaration of function 'dpll_device_register'; did you mean 'mtd_device_register'? [-Werror=implicit-function-declaration]
3864 | dpll_device_register(bp->dpll);
| ^~~~~~~~~~~~~~~~~~~~
| mtd_device_register
drivers/ptp/ptp_ocp.c: In function 'ptp_ocp_remove':
drivers/ptp/ptp_ocp.c:3883:9: error: implicit declaration of function 'dpll_device_unregister'; did you mean 'mtd_device_unregister'? [-Werror=implicit-function-declaration]
3883 | dpll_device_unregister(bp->dpll);
| ^~~~~~~~~~~~~~~~~~~~~~
| mtd_device_unregister
drivers/ptp/ptp_ocp.c:3884:9: error: implicit declaration of function 'dpll_device_free' [-Werror=implicit-function-declaration]
3884 | dpll_device_free(bp->dpll);
| ^~~~~~~~~~~~~~~~
drivers/ptp/ptp_ocp.c: At top level:
drivers/ptp/ptp_ocp.c:3794:31: error: storage size of 'dpll_ops' isn't known
3794 | static struct dpll_device_ops dpll_ops = {
| ^~~~~~~~
cc1: some warnings being treated as errors

vim +/const +3743 drivers/ptp/ptp_ocp.c

3736
3737 static int ptp_ocp_sma_get_dpll_type(struct ptp_ocp *bp, int sma_nr)
3738 {
3739 struct ocp_selector *tbl;
3740 u32 val;
3741
3742 if (bp->sma[sma_nr].mode == SMA_MODE_IN)
> 3743 tbl = bp->sma_op->tbl[0];
3744 else
3745 tbl = bp->sma_op->tbl[1];
3746
3747 val = ptp_ocp_sma_get(bp, sma_nr);
3748 return tbl[val].dpll_type;
3749 }
3750
3751 static int ptp_ocp_dpll_type_supported(struct dpll_device *dpll, int sma, int type, int dir)
3752 {
3753 struct ptp_ocp *bp = (struct ptp_ocp *)dpll_priv(dpll);
> 3754 struct ocp_selector *tbl = bp->sma_op->tbl[dir];
3755 int i;
3756
3757 for (i = 0; i < sizeof(*tbl); i++) {
3758 if (tbl[i].dpll_type == type)
3759 return 1;
3760 }
3761 return 0;
3762 }
3763
3764 static int ptp_ocp_dpll_get_source_type(struct dpll_device *dpll, int sma)
3765 {
3766 struct ptp_ocp *bp = (struct ptp_ocp *)dpll_priv(dpll);
3767
3768 if (bp->sma[sma].mode != SMA_MODE_IN)
3769 return -1;
3770
3771 return ptp_ocp_sma_get_dpll_type(bp, sma);
3772 }
3773
3774 static int ptp_ocp_dpll_get_source_supported(struct dpll_device *dpll, int sma, int type)
3775 {
3776 return ptp_ocp_dpll_type_supported(dpll, sma, type, 0);
3777 }
3778
3779 static int ptp_ocp_dpll_get_output_type(struct dpll_device *dpll, int sma)
3780 {
3781 struct ptp_ocp *bp = (struct ptp_ocp *)dpll_priv(dpll);
3782
3783 if (bp->sma[sma].mode != SMA_MODE_OUT)
3784 return -1;
3785
3786 return ptp_ocp_sma_get_dpll_type(bp, sma);
3787 }
3788
3789 static int ptp_ocp_dpll_get_output_supported(struct dpll_device *dpll, int sma, int type)
3790 {
3791 return ptp_ocp_dpll_type_supported(dpll, sma, type, 1);
3792 }
3793
3794 static struct dpll_device_ops dpll_ops = {
> 3795 .get_status = ptp_ocp_dpll_get_status,
3796 .get_lock_status = ptp_ocp_dpll_get_lock_status,
3797 .get_source_type = ptp_ocp_dpll_get_source_type,
3798 .get_source_supported = ptp_ocp_dpll_get_source_supported,
3799 .get_output_type = ptp_ocp_dpll_get_output_type,
3800 .get_output_supported = ptp_ocp_dpll_get_output_supported,
3801 };
3802
3803 static int
3804 ptp_ocp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
3805 {
3806 struct devlink *devlink;
3807 struct ptp_ocp *bp;
3808 int err;
3809
3810 devlink = devlink_alloc(&ptp_ocp_devlink_ops, sizeof(*bp), &pdev->dev);
3811 if (!devlink) {
3812 dev_err(&pdev->dev, "devlink_alloc failed\n");
3813 return -ENOMEM;
3814 }
3815
3816 err = pci_enable_device(pdev);
3817 if (err) {
3818 dev_err(&pdev->dev, "pci_enable_device\n");
3819 goto out_free;
3820 }
3821
3822 bp = devlink_priv(devlink);
3823 err = ptp_ocp_device_init(bp, pdev);
3824 if (err)
3825 goto out_disable;
3826
3827 /* compat mode.
3828 * Older FPGA firmware only returns 2 irq's.
3829 * allow this - if not all of the IRQ's are returned, skip the
3830 * extra devices and just register the clock.
3831 */
3832 err = pci_alloc_irq_vectors(pdev, 1, 17, PCI_IRQ_MSI | PCI_IRQ_MSIX);
3833 if (err < 0) {
3834 dev_err(&pdev->dev, "alloc_irq_vectors err: %d\n", err);
3835 goto out;
3836 }
3837 bp->n_irqs = err;
3838 pci_set_master(pdev);
3839
3840 err = ptp_ocp_register_resources(bp, id->driver_data);
3841 if (err)
3842 goto out;
3843
3844 bp->ptp = ptp_clock_register(&bp->ptp_info, &pdev->dev);
3845 if (IS_ERR(bp->ptp)) {
3846 err = PTR_ERR(bp->ptp);
3847 dev_err(&pdev->dev, "ptp_clock_register: %d\n", err);
3848 bp->ptp = NULL;
3849 goto out;
3850 }
3851
3852 err = ptp_ocp_complete(bp);
3853 if (err)
3854 goto out;
3855
3856 ptp_ocp_info(bp);
3857 devlink_register(devlink);
3858
> 3859 bp->dpll = dpll_device_alloc(&dpll_ops, ARRAY_SIZE(bp->sma), ARRAY_SIZE(bp->sma), bp);
3860 if (!bp->dpll) {
3861 dev_err(&pdev->dev, "dpll_device_alloc failed\n");
3862 return 0;
3863 }
3864 dpll_device_register(bp->dpll);
3865
3866 return 0;
3867
3868 out:
3869 ptp_ocp_detach(bp);
3870 out_disable:
3871 pci_disable_device(pdev);
3872 out_free:
3873 devlink_free(devlink);
3874 return err;
3875 }
3876

--
0-DAY CI Kernel Test Service
https://01.org/lkp

Next message: James Hilliard: "Re: [PATCH] libbpf: ensure functions with always_inline attribute are inline"
Previous message: Benson Leung: "Re: [PATCH] Supporting wake on DP hot events behind TBT/USB4 routers"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]