Re: [PATCH v2] pmic: add mt6366 regulator document

[Rex-BC Chen]

On Thu, 2022-07-28 at 18:46 +0800, Krzysztof Kozlowski wrote:
> On 28/07/2022 08:27, Zhiyong Tao wrote:
> > From: zhiyong tao <zhiyong.tao@xxxxxxxxxxxx>
> > 
> > Add mt6366 regulator document
> 
> As usual with Mediatek your emails fail to properly pass modern SMTP
> checks and you end up in spam.
> 
> I reported it months ago to folks in Mediatek. No improvements since
> that time.
> 
> I stopped checking my spam folder for Mediatek stuff and all will be
> ignored. I will also stop complaining about it - just ignore
> Mediatek.
> 
> Fix your systems, instead of putting additional effort on community
> and
> on reviewers.
> 

Hello Krzysztof,

I am Rex from MediaTek chrome project team.
We noticed your complain of our upstream mail.

First of all, sorry for the inconvenience.
We really want to fix this SPAM issue.

>From our side, we can make sure mails for kernel upstream from MediaTek
is clear and these mails pass the verification of DMARC/DKIM/SPF.
Therefore, to identify the root cause, could you please provide us some
mails that seen as SPAM from MediaTek?
It's more useful if you can use the form of attachment. In that case,
we can analyze whole mails including mail headers.

We really appreciate your big support, and we hope we can fix this
issue to reduce the inconvenience for reviewing series from MediaTek.
If you can spare some time to help us for this, it would very helpful!!

Our IT also adjust the DKIM setting today. If the situation of this
issue it much better, please also let us know.

Many thanks!!

BRs,
Rex
> 
> > 
> > Signed-off-by: zhiyong tao <zhiyong.tao@xxxxxxxxxxx>
> > ---
> >  .../regulator/mediatek,mt6366-regulator.yaml  | 375
> > ++++++++++++++++++
> >  1 file changed, 375 insertions(+)
> 
> Subject does not match subsystem.
> 
> 
> >  create mode 100755
> > Documentation/devicetree/bindings/regulator/mediatek,mt6366-
> > regulator.yaml
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/regulator/mediatek,mt6366-
> > regulator.yaml
> > b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-
> > regulator.yaml
> > new file mode 100755
> > index 000000000000..eb72c64757cf
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/mediatek,mt6366-
> > regulator.yaml
> > @@ -0,0 +1,375 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: 
> >
 https://urldefense.com/v3/__http://devicetree.org/schemas/regulator/mediatek,mt6366-regulator.yaml*__;Iw!!CTRNKA9wMg0ARbw!3B-3NHQAsJc6ov022NnUIctYLEyx-BfxG5s85TBBvEfGjc4DdYDIqG_Ka_5D7scVo8CRtzLqokEX_thhM7XK_S90wg$
> > +$schema: 
> >
 https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!3B-3NHQAsJc6ov022NnUIctYLEyx-BfxG5s85TBBvEfGjc4DdYDIqG_Ka_5D7scVo8CRtzLqokEX_thhM7Un6TPZdw$
> > +
> > +title: MT6366 Regulator from MediaTek Integrated
> > +
> > +maintainers:
> > +  - Zhiyong Tao <zhiyong.tao@xxxxxxxxxxxx>
> > +
> > +description: |
> > +  List of regulators provided by this controller. It is named
> > +  according to its regulator type, buck_<name> and ldo_<name>.
> > +  MT6366 regulators node should be sub node of the MT6397 MFD
> > node.
> > +
> > +properties:
> > +  compatible:
> > +    const: mediatek,mt6366-regulator
> > +
> > +  regulators:
> > +    type: object
> > +    description: List of regulators and its properties
> > +
> > +    patternProperties:
> > +      "^buck-
> > v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$":
> > +        type: object
> > +        $ref: "regulator.yaml#"
> 
> No need for quotes.
> 
> > +        unevaluatedProperties: false
> > +
> > +        properties:
> > +          regulator-name:
> > +            pattern:
> > "^v(dram1|core|coresshub|proc11|proc12|gpu|s2|modem|s1)$"
> 
> Why do you enforce specific regulator-name? Remove.
> 
> > +
> > +      "^ldo-v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$":
> > +        type: object
> > +        $ref: "regulator.yaml#"
> > +
> > +        properties:
> > +          regulator-name:
> > +            pattern:
> > "^v(dram2|sim1|ibr|rf12|usb|camio|camd|cn18|fe28)$"
> > +
> > +      "^ldo-v(xo22|efuse|mch|vcama1|emc|a12|vcama2|mc)$":
> > +        type: object
> > +        $ref: "regulator.yaml#"
> > +
> > +        properties:
> > +          regulator-name:
> > +            pattern:
> > "^v(xo22|efuse|mch|vcama1|emc|a12|vcama2|mc)$"
> > +
> > +      "^buck-(vcore)-sshub$":
> > +        type: object
> > +        $ref: "regulator.yaml#"
> > +        unevaluatedProperties: false
> > +
> > +        properties:
> > +          regulator-name:
> > +            pattern: "^vcore-sshub$"
> > +
> > +      "^ldo-vcn(28|33)-bt$":
> > +        type: object
> > +        $ref: "regulator.yaml#"
> > +        unevaluatedProperties: false
> > +
> > +        properties:
> > +          regulator-name:
> > +            pattern: "^vcn(28|33)-bt$"
> > +
> > +      "^ldo-vcn(33)-wifi$":
> > +        type: object
> > +        $ref: "regulator.yaml#"
> > +        unevaluatedProperties: false
> > +
> > +        properties:
> > +          regulator-name:
> > +            pattern: "^vcn33-wifi$"
> > +
> > +      "^ldo-vsram-(others)-sshub$":
> > +        type: object
> > +        $ref: "regulator.yaml#"
> > +        unevaluatedProperties: false
> > +
> > +        properties:
> > +          regulator-name:
> > +            pattern: "^vsram-others-sshub$"
> > +
> > +      "^ldo-vsram-(proc11|others|gpu|proc12)$":
> > +        type: object
> > +        $ref: "regulator.yaml#"
> > +        unevaluatedProperties: false
> > +
> > +        properties:
> > +          regulator-name:
> > +            pattern: "^vsram-(proc11|others|gpu|proc12)$"
> > +
> > +      "^ldo-v(aud|bif|io|ldo)28$":
> > +        type: object
> > +        $ref: "regulator.yaml#"
> > +
> > +        properties:
> > +          regulator-name:
> > +            pattern: "^v(aud|bif|io|ldo)28$"
> > +
> > +      "^ldo-v(io|aux|rf)18$":
> > +        type: object
> > +        $ref: "regulator.yaml#"
> > +
> > +        properties:
> > +          regulator-name:
> > +            pattern: "^v(io|aux|rf)18$"
> > +
> > +      "^ldo-vsim[2]$":
> > +        type: object
> > +        $ref: "regulator.yaml#"
> > +
> > +        properties:
> > +          regulator-name:
> > +            pattern: "^vsim2$"
> > +
> > +        required:
> > +          - regulator-name
> > +
> > +required:
> > +  - compatible
> > +  - regulators
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    pmic {
> > +      compatible = "mediatek,mt6366-regulator";
> > +
> > +      regulators {
> > +        mt6366_vdram1_reg: buck-vdram1 {
> > +            regulator-name = "vdram1";
> 
> Messed up indentation. Use only one, so 4 space for DTS example.
> 
> 
> 
> Best regards,
> Krzysztof