Re: [PATCH v1 1/1] leds: an30259a: Get rid of custom led_init_default_state_get()
From: kernel test robot
Date: Tue Aug 02 2022 - 19:43:45 EST
Hi Andy,
I love your patch! Perhaps something to improve:
[auto build test WARNING on pavel-leds/for-next]
[also build test WARNING on linus/master v5.19 next-20220728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/leds-an30259a-Get-rid-of-custom-led_init_default_state_get/20220803-053038
base: git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next
config: x86_64-randconfig-a005-20220801 (https://download.01.org/0day-ci/archive/20220803/202208030728.77z65TO4-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 52cd00cabf479aa7eb6dbb063b7ba41ea57bce9e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/757448b8fc5bcbc4303ce9570d5dd555f1e2b22e
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Andy-Shevchenko/leds-an30259a-Get-rid-of-custom-led_init_default_state_get/20220803-053038
git checkout 757448b8fc5bcbc4303ce9570d5dd555f1e2b22e
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/leds/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
drivers/leds/leds-an30259a.c:227:24: error: call to undeclared function 'led_init_default_state_get'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
led->default_state = led_init_default_state_get(led->fwnode);
^
>> drivers/leds/leds-an30259a.c:204:14: warning: unused variable 'str' [-Wunused-variable]
const char *str;
^
1 warning and 1 error generated.
vim +/str +204 drivers/leds/leds-an30259a.c
2d00f35c55e74f Simon Shields 2018-09-09 197
2d00f35c55e74f Simon Shields 2018-09-09 198 static int an30259a_dt_init(struct i2c_client *client,
2d00f35c55e74f Simon Shields 2018-09-09 199 struct an30259a *chip)
2d00f35c55e74f Simon Shields 2018-09-09 200 {
8853c95e997e0a Marek Behún 2020-09-18 201 struct device_node *np = dev_of_node(&client->dev), *child;
2d00f35c55e74f Simon Shields 2018-09-09 202 int count, ret;
2d00f35c55e74f Simon Shields 2018-09-09 203 int i = 0;
2d00f35c55e74f Simon Shields 2018-09-09 @204 const char *str;
2d00f35c55e74f Simon Shields 2018-09-09 205 struct an30259a_led *led;
2d00f35c55e74f Simon Shields 2018-09-09 206
99a013c840a050 Marek Behún 2020-09-18 207 count = of_get_available_child_count(np);
2d00f35c55e74f Simon Shields 2018-09-09 208 if (!count || count > AN30259A_MAX_LEDS)
2d00f35c55e74f Simon Shields 2018-09-09 209 return -EINVAL;
2d00f35c55e74f Simon Shields 2018-09-09 210
2d00f35c55e74f Simon Shields 2018-09-09 211 for_each_available_child_of_node(np, child) {
2d00f35c55e74f Simon Shields 2018-09-09 212 u32 source;
2d00f35c55e74f Simon Shields 2018-09-09 213
2d00f35c55e74f Simon Shields 2018-09-09 214 ret = of_property_read_u32(child, "reg", &source);
2d00f35c55e74f Simon Shields 2018-09-09 215 if (ret != 0 || !source || source > AN30259A_MAX_LEDS) {
2d00f35c55e74f Simon Shields 2018-09-09 216 dev_err(&client->dev, "Couldn't read LED address: %d\n",
2d00f35c55e74f Simon Shields 2018-09-09 217 ret);
2d00f35c55e74f Simon Shields 2018-09-09 218 count--;
2d00f35c55e74f Simon Shields 2018-09-09 219 continue;
2d00f35c55e74f Simon Shields 2018-09-09 220 }
2d00f35c55e74f Simon Shields 2018-09-09 221
2d00f35c55e74f Simon Shields 2018-09-09 222 led = &chip->leds[i];
2d00f35c55e74f Simon Shields 2018-09-09 223
2d00f35c55e74f Simon Shields 2018-09-09 224 led->num = source;
2d00f35c55e74f Simon Shields 2018-09-09 225 led->chip = chip;
1817208e14c6f7 Jacek Anaszewski 2019-06-09 226 led->fwnode = of_fwnode_handle(child);
757448b8fc5bcb Andy Shevchenko 2022-08-03 227 led->default_state = led_init_default_state_get(led->fwnode);
2d00f35c55e74f Simon Shields 2018-09-09 228
2d00f35c55e74f Simon Shields 2018-09-09 229 i++;
2d00f35c55e74f Simon Shields 2018-09-09 230 }
2d00f35c55e74f Simon Shields 2018-09-09 231
2d00f35c55e74f Simon Shields 2018-09-09 232 if (!count)
2d00f35c55e74f Simon Shields 2018-09-09 233 return -EINVAL;
2d00f35c55e74f Simon Shields 2018-09-09 234
2d00f35c55e74f Simon Shields 2018-09-09 235 chip->num_leds = i;
2d00f35c55e74f Simon Shields 2018-09-09 236
2d00f35c55e74f Simon Shields 2018-09-09 237 return 0;
2d00f35c55e74f Simon Shields 2018-09-09 238 }
2d00f35c55e74f Simon Shields 2018-09-09 239
--
0-DAY CI Kernel Test Service
https://01.org/lkp