Re: [GIT PULL] Smack patches for v6.0

From: Linus Torvalds
Date: Tue Aug 02 2022 - 18:11:53 EST


On Mon, Aug 1, 2022 at 1:13 PM Casey Schaufler <casey@xxxxxxxxxxxxxxxx> wrote:
>
> There are two minor code clean-ups. One removes a touch of
> dead code and the other replaces an instance of kzalloc + strncpy
> with kstrndup.

Hmm. That second one looks like it really should have just used
"kmemdup()" (and a zero termination) instead, since it has already
done all the string length calculations.

Oh well. I guess the strndup() works too, but it seems kind of odd to
do a strnlen() there when you have literally limited 'len' to smaller
than the string you are going to duplicate.

Linus