Re: [PATCH] RDMA/ib_srpt: unify checking rdma_cm_id condition in srpt_cm_req_recv()

From: Bart Van Assche
Date: Tue Aug 02 2022 - 13:28:48 EST


On 8/1/22 20:35, lizhijian@xxxxxxxxxxx wrote:
On 02/08/2022 00:46, Bart Van Assche wrote:
Although the above patch looks fine to me, I'm not sure this kind
of changes should be considered as useful or as churn?

Just want to make it more clear :). you can see below cleanup path,
it's checking rdma_cm_id instead. When i first saw these conditions,
i was confused until i realized rdma_cm_id and ib_cm_id are always
exclusive currently after looking into its callers

Ah, that's right. Thanks for the clarification.

Bart.