Re: [PATCH] ASoC: imx-rpmsg: Support configure sysclk for codec dai

From: Mark Brown
Date: Tue Aug 02 2022 - 09:02:21 EST


On Tue, Aug 02, 2022 at 08:23:37PM +0800, Shengjiu Wang wrote:
> On Tue, Aug 2, 2022 at 1:47 AM Nicolin Chen <nicoleotsuka@xxxxxxxxx> wrote:
> > On Mon, Aug 1, 2022 at 5:42 AM Shengjiu Wang <shengjiu.wang@xxxxxxx>
> > wrote:

> > > struct imx_rpmsg {
> > > struct snd_soc_dai_link dai;
> > > struct snd_soc_card card;
> > > + unsigned int sysclk;

> > unsigned long?

> Seems int or long are all used in the kernel.
> I am not sure which one is better?

clk_get_rate() and clk_set_rate() do use unsigned long, but on a lot of
architectures that is the same size as int so it makes little practical
difference though it would be more correct to use an unsigned long.

Attachment: signature.asc
Description: PGP signature