Re: [PATCH v2 1/1] platform/x86: p2sb: Move out of X86_PLATFORM_DEVICES dependency

From: Lee Jones
Date: Mon Aug 01 2022 - 09:22:44 EST


On Thu, 28 Jul 2022, Hans de Goede wrote:

> Hi,
>
> On 7/18/22 16:53, Andy Shevchenko wrote:
> > The P2SB library is used for various drivers, including server
> > platforms. That's why the dependency on X86_PLATFORM_DEVICES
> > seems superfluous.
> >
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> > ---
> > v2: added X86 to the dependencies of P2SB (Hans), added Rb tag (Hans)
>
> Lee I presume that since you've merged the original series
> (in your ib-mfd-edac-i2c-leds-pinctrl-platform-watchdog-5.20
> branch) that you will take this fix on top ?

The point of supplying an immutable branch is that whoever maintains
this subsystem can pull from it and apply this patch on-top.

> This fix is necessary to fix a bunch of randconfig build
> failures in the current linux-next.
>
> > drivers/platform/x86/Kconfig | 12 ++++++++++++
> > drivers/platform/x86/Makefile | 4 ++++
> > drivers/platform/x86/intel/Kconfig | 12 ------------
> > drivers/platform/x86/intel/Makefile | 2 --
> > drivers/platform/x86/{intel => }/p2sb.c | 0
> > 5 files changed, 16 insertions(+), 14 deletions(-)
> > rename drivers/platform/x86/{intel => }/p2sb.c (100%)

--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog