Re: [PATCH] iommu/amd: Fix compile warning in init code

[Suthikulpanit, Suravee]

On 7/29/2022 5:04 PM, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@xxxxxxx>
>
> A recent commit introduced these compile warnings:
>
>    CC      drivers/iommu/amd/init.o
> drivers/iommu/amd/init.c:938:12: error: ‘iommu_init_ga_log’ defined but not used [-Werror=unused-function]
>    938 | static int iommu_init_ga_log(struct amd_iommu *iommu)
>        |            ^~~~~~~~~~~~~~~~~
> drivers/iommu/amd/init.c:902:12: error: ‘iommu_ga_log_enable’ defined but not used [-Werror=unused-function]
>    902 | static int iommu_ga_log_enable(struct amd_iommu *iommu)
>        |            ^~~~~~~~~~~~~~~~~~~
>
> The warnings appear because both functions are defined when IRQ
> remapping is not enabled, but only used when IRQ remapping is enabled.
>
> Fix it by only defining the functions when IRQ remapping is enabled.
>
> Fixes: c5e1a1eb9279 ("iommu/amd: Simplify and Consolidate Virtual APIC (AVIC) Enablement")
> Signed-off-by: Joerg Roedel <jroedel@xxxxxxx>

Ah... sorry. I missed this part.

Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>

Thank you,
Suravee