Re: [PATCH v2] ufs: core: ufshcd: use local_clock() for debugging timestamps

[Stanley Chu]

Hi,

On Mon, Aug 1, 2022 at 12:30 PM Daniil Lunev <dlunev@xxxxxxxxxxxx> wrote:
>
> CLOCK_MONOTONIC is not advanced when the system is in suspend. This
> becomes problematic when debugging issues related to suspend-resume:
> the timestamps printed by ufshcd_print_trs can not be correlated with
> dmesg entries, which are timestamped with local_clock().
>
> This patch changes the used clock to local_clock() for the informational
> timestamp variables and adds mirroring *_local_clock instances for
> variables used in subsequent derevations (to not change the semantics of
> those derevations).
>
> Signed-off-by: Daniil Lunev <dlunev@xxxxxxxxxxxx>
>
I am not sure if it is better to keep only one kind of timestamp in
the UFS driver.

Either way, it looks good to me.

Acked-by: Stanley Chu <stanley.chu@xxxxxxxxxxxx>