Re: [PATCH] keys/keyctl: Use kfree_rcu instead of kfree

From: Siddh Raman Pant
Date: Sat Jul 23 2022 - 11:28:58 EST


On Sat, 23 Jul 2022 20:13:11 +0530 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> You need to explain all of this in a changelog text. Don't say what you
> do, but say why you are doing it.

Okay, I will keep this in mind next time.

> > > And how was this tested?
> >
> > It compiles locally for me, and I used syzbot on this along with testing the
> > other `watch_queue_clear` patch, which generated no errors.
>
> How does the watch queue stuff relate to this keyctl logic?
>
> Again, be specific as to why you are doing things.

It doesn't relate, I just wanted to say that syzbot didn't crash too (I had
this change in the same branch as that patch for testing, and syzbot compiled
it successfully).

Sorry for the confusion.

Though now as James has pointed out, this patch isn't needed.

Apologies,
Siddh