Re: [PATCH] hfsplus: Fix code typo

From: Matthew Wilcox
Date: Fri Jul 22 2022 - 17:33:21 EST


On Sat, Jul 23, 2022 at 03:51:33AM +0800, Xin Gao wrote:
> The double `free' is duplicated in line 498, remove one.

This is wrong. The intended meaning here is "trying to free bnode
which is already free". Please don't send patches for code you don't
understand.

> Signed-off-by: Xin Gao <gaoxin@xxxxxxxxxx>
> ---
> fs/hfsplus/btree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/hfsplus/btree.c b/fs/hfsplus/btree.c
> index 66774f4cb4fd..655cf60eabbf 100644
> --- a/fs/hfsplus/btree.c
> +++ b/fs/hfsplus/btree.c
> @@ -495,7 +495,7 @@ void hfs_bmap_free(struct hfs_bnode *node)
> m = 1 << (~nidx & 7);
> byte = data[off];
> if (!(byte & m)) {
> - pr_crit("trying to free free bnode "
> + pr_crit("trying to free bnode "
> "%u(%d)\n",
> node->this, node->type);
> kunmap(page);
> --
> 2.30.2
>