[PATCH] x86, cpu: use MSR_IA32_MISC_ENABLE constants
From: Paolo Bonzini
Date: Tue Jul 19 2022 - 13:47:23 EST
- Next message: kernel test robot: "drivers/iio/dac/ad5766.c:109:8: warning: Excessive padding in 'struct ad5766_state' (44 padding bytes, where 12 is optimal). Optimal fields order: data, spi, chip_info, gpio_reset, crt_range, dither_source, dither_scale, lock, dither_enable, dither_invert..."
- Previous message: Dave Hansen: "Re: [PATCH v5 02/22] cc_platform: Add new attribute to prevent ACPI CPU hotplug"
- Next in thread: tip-bot2 for Paolo Bonzini: "[tip: x86/cpu] x86/cpu: Use MSR_IA32_MISC_ENABLE constants"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Instead of the magic numbers 1<<11 and 1<<12 use the constants
from msr-index.h. This makes it obvious where those bits
of MSR_IA32_MISC_ENABLE are consumed (and in fact that Linux
consumes them at all) to simple minds that grep for
MSR_IA32_MISC_ENABLE_.*_UNAVAIL.
Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
---
arch/x86/kernel/cpu/intel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index fd5dead8371c..663f6e6dd288 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -682,9 +682,9 @@ static void init_intel(struct cpuinfo_x86 *c)
unsigned int l1, l2;
rdmsr(MSR_IA32_MISC_ENABLE, l1, l2);
- if (!(l1 & (1<<11)))
+ if (!(l1 & MSR_IA32_MISC_ENABLE_BTS_UNAVAIL))
set_cpu_cap(c, X86_FEATURE_BTS);
- if (!(l1 & (1<<12)))
+ if (!(l1 & MSR_IA32_MISC_ENABLE_PEBS_UNAVAIL))
set_cpu_cap(c, X86_FEATURE_PEBS);
}
--
2.31.1
- Next message: kernel test robot: "drivers/iio/dac/ad5766.c:109:8: warning: Excessive padding in 'struct ad5766_state' (44 padding bytes, where 12 is optimal). Optimal fields order: data, spi, chip_info, gpio_reset, crt_range, dither_source, dither_scale, lock, dither_enable, dither_invert..."
- Previous message: Dave Hansen: "Re: [PATCH v5 02/22] cc_platform: Add new attribute to prevent ACPI CPU hotplug"
- Next in thread: tip-bot2 for Paolo Bonzini: "[tip: x86/cpu] x86/cpu: Use MSR_IA32_MISC_ENABLE constants"
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]