Re: [PATCH] efi/x86: use naked RET on mixed mode call wrapper

From: Borislav Petkov
Date: Tue Jul 19 2022 - 13:37:59 EST


On Tue, Jul 19, 2022 at 05:22:28PM +0200, Ard Biesheuvel wrote:
> The code in question is a little trampoline that executes from the EFI
> mixed mode 1:1 mapping of the kernel text, and never via the kernel
> mapping, so we should just move it into .rodata instead (and fix up
> the mixed mode virtual address map logic accordingly). I don't think
> mapping the kernel text and rodata into the 1;1 EFI map is needed at
> all, tbh, and the only thing we ever access via that mapping is that
> little trampoline.
>
> Something like

I'm obviously always for simplifications like that. I'm guessing this
should be tested for a full next release before it goes to Linus?

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette