Re: Re: [PATCH V3] mm: prevent page_frag_alloc() from corrupting the memory

From: Alexander Duyck
Date: Mon Jul 18 2022 - 11:33:59 EST


On Mon, Jul 18, 2022 at 8:25 AM Maurizio Lombardi <mlombard@xxxxxxxxxx> wrote:
>
> po 18. 7. 2022 v 16:40 odesílatel Chen Lin <chen45464546@xxxxxxx> napsal:
> >
> > But the original intention of page frag interface is indeed to allocate memory
> > less than one page. It's not a good idea to complicate the definition of
> > "page fragment".
>
> I see your point, I just don't think it makes much sense to break
> drivers here and there
> when a practically identical 2-lines patch can fix the memory corruption bug
> without changing a single line of code in the drivers.
>
> By the way, I will wait for the maintainers to decide on the matter.
>
> Maurizio

I'm good with this smaller approach. If it fails only under memory
pressure I am good with that. The issue with the stricter checking is
that it will add additional overhead that doesn't add much value to
the code.

Thanks,

- Alex