Re: [PATCH] staging: rtl8192u: fix rmmod warn when wlan0 is renamed

[Dan Carpenter]

On Sun, Jul 17, 2022 at 12:01:57AM -0700, Tong Zhang wrote:
> -static int __maybe_unused proc_get_stats_rx(struct seq_file *m, void *v)
> -{
> -	struct net_device *dev = m->private;
> -	struct r8192_priv *priv = (struct r8192_priv *)ieee80211_priv(dev);
> -
> -	seq_printf(m,
> -		   "RX packets: %lu\n"
> -		   "RX urb status error: %lu\n"
> -		   "RX invalid urb error: %lu\n",
> -		   priv->stats.rxoktotal,
> -		   priv->stats.rxstaterr,
> -		   priv->stats.rxurberr);
> -
> -	return 0;
> -}

> +static int rtl8192_usb_stats_rx_show(struct seq_file *m, void *v)
> +{
> +	struct net_device *dev = m->private;
> +	struct r8192_priv *priv = (struct r8192_priv *)ieee80211_priv(dev);
> +
> +	seq_printf(m,
> +			"RX packets: %lu\n"
> +			"RX urb status error: %lu\n"
> +			"RX invalid urb error: %lu\n",
> +			priv->stats.rxoktotal,
> +			priv->stats.rxstaterr,
> +			priv->stats.rxurberr);
> +
> +	return 0;
> +}

When you're moving function around, then try to avoid changing the white
space at all.  It just makes it more complicated to review.  But
especially in this case, the white space was correct-ish in the original
and now it is bad.

regards,
dan carpenter