[PATCH -next] ublk_drv: fix missing error return code in ublk_add_dev()

From: Yang Yingliang
Date: Mon Jul 18 2022 - 00:15:03 EST


If blk_mq_init_queue() fails, it should return error code in ublk_add_dev()

Fixes: cebbe577cb17 ("ublk_drv: fix request queue leak")
Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
---
drivers/block/ublk_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
index 52fd0af8a4f2..bea441782cb0 100644
--- a/drivers/block/ublk_drv.c
+++ b/drivers/block/ublk_drv.c
@@ -1169,8 +1169,10 @@ static int ublk_add_dev(struct ublk_device *ub)
goto out_deinit_queues;

ub->ub_queue = blk_mq_init_queue(&ub->tag_set);
- if (IS_ERR(ub->ub_queue))
+ if (IS_ERR(ub->ub_queue)) {
+ err = PTR_ERR(ub->ub_queue);
goto out_cleanup_tags;
+ }
ub->ub_queue->queuedata = ub;

disk = ub->ub_disk = blk_mq_alloc_disk_for_queue(ub->ub_queue,
--
2.25.1