Re: [PATCH] clk: qcom: Drop mmcx gdsc supply for dispcc and videocc

[Dmitry Baryshkov]

On Sun, 17 Jul 2022 at 07:21, Bjorn Andersson
<bjorn.andersson@xxxxxxxxxx> wrote:
>
> On Wed 13 Jul 09:32 CDT 2022, Abel Vesa wrote:
>
> > Both dispcc and videocc use mmcx power domain now.
> > Lets drop the supply mmcx from every gdsc.
> >
> > Cc: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > Fixes: 266e5cf39a0f ("arm64: dts: qcom: sm8250: remove mmcx regulator")
> > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
>
> This would break backwards compatibility with dtbs that used
> mmcx-supply. We only ever used mmcx-supply in sm8250.dtsi upstream and
> given that we only boot sm8250 off Android boot images it's unlikely
> that anyone would use a new kernel with that old of a dtb...
>
> So:
> Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
>
> Dmitry, what do you think?

I think it's fine.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

>
> Regards,
> Bjorn
>
> > ---
> >  drivers/clk/qcom/dispcc-sm8250.c  | 1 -
> >  drivers/clk/qcom/videocc-sm8250.c | 4 ----
> >  2 files changed, 5 deletions(-)
> >
> > diff --git a/drivers/clk/qcom/dispcc-sm8250.c b/drivers/clk/qcom/dispcc-sm8250.c
> > index 39b344ebb049..709076f0f9d7 100644
> > --- a/drivers/clk/qcom/dispcc-sm8250.c
> > +++ b/drivers/clk/qcom/dispcc-sm8250.c
> > @@ -1138,7 +1138,6 @@ static struct gdsc mdss_gdsc = {
> >       },
> >       .pwrsts = PWRSTS_OFF_ON,
> >       .flags = HW_CTRL,
> > -     .supply = "mmcx",
> >  };
> >
> >  static struct clk_regmap *disp_cc_sm8250_clocks[] = {
> > diff --git a/drivers/clk/qcom/videocc-sm8250.c b/drivers/clk/qcom/videocc-sm8250.c
> > index 8617454e4a77..f28f2cb051d7 100644
> > --- a/drivers/clk/qcom/videocc-sm8250.c
> > +++ b/drivers/clk/qcom/videocc-sm8250.c
> > @@ -277,7 +277,6 @@ static struct gdsc mvs0c_gdsc = {
> >       },
> >       .flags = 0,
> >       .pwrsts = PWRSTS_OFF_ON,
> > -     .supply = "mmcx",
> >  };
> >
> >  static struct gdsc mvs1c_gdsc = {
> > @@ -287,7 +286,6 @@ static struct gdsc mvs1c_gdsc = {
> >       },
> >       .flags = 0,
> >       .pwrsts = PWRSTS_OFF_ON,
> > -     .supply = "mmcx",
> >  };
> >
> >  static struct gdsc mvs0_gdsc = {
> > @@ -297,7 +295,6 @@ static struct gdsc mvs0_gdsc = {
> >       },
> >       .flags = HW_CTRL,
> >       .pwrsts = PWRSTS_OFF_ON,
> > -     .supply = "mmcx",
> >  };
> >
> >  static struct gdsc mvs1_gdsc = {
> > @@ -307,7 +304,6 @@ static struct gdsc mvs1_gdsc = {
> >       },
> >       .flags = HW_CTRL,
> >       .pwrsts = PWRSTS_OFF_ON,
> > -     .supply = "mmcx",
> >  };
> >
> >  static struct clk_regmap *video_cc_sm8250_clocks[] = {
> > --
> > 2.34.3
> >



-- 
With best wishes
Dmitry