Re: [PATCH] iio: magnetometer: rm3100: do not explicity set INDIO_BUFFER_TRIGGERED mode
From: Jonathan Cameron
Date: Sat Jul 16 2022 - 12:49:11 EST
On Sat, 2 Jul 2022 10:50:05 +0200
Marcus Folkesson <marcus.folkesson@xxxxxxxxx> wrote:
> The core sets INDIO_BUFFER_TRIGGERED as part of
> devm_iio_triggered_buffer_setup().
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@xxxxxxxxx>
You seem to be on a fairly old tree.
Anyhow, the issue is still there, so I dealt with the fuzz.
Applied to the togreg branch of iio.git and pushed out as testing for 0-day
to poke at it. Not I'll be rebasing on rc1 once available.
Thanks,
Jonathan
> ---
> drivers/iio/magnetometer/rm3100-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/magnetometer/rm3100-core.c b/drivers/iio/magnetometer/rm3100-core.c
> index 26195733ea3e..060914c63969 100644
> --- a/drivers/iio/magnetometer/rm3100-core.c
> +++ b/drivers/iio/magnetometer/rm3100-core.c
> @@ -552,7 +552,7 @@ int rm3100_common_probe(struct device *dev, struct regmap *regmap, int irq)
> indio_dev->info = &rm3100_info;
> indio_dev->channels = rm3100_channels;
> indio_dev->num_channels = ARRAY_SIZE(rm3100_channels);
> - indio_dev->modes = INDIO_DIRECT_MODE | INDIO_BUFFER_TRIGGERED;
> + indio_dev->modes = INDIO_DIRECT_MODE;
> indio_dev->currentmode = INDIO_DIRECT_MODE;
>
> if (!irq)