Re: [PATCH 10/12] cpufreq: cpufreq: export cpufreq cpu release and acquire

From: Nathan Fontenot
Date: Thu Jul 07 2022 - 15:40:40 EST


On 7/7/22 12:01, Perry Yuan wrote:
> cpufreq_cpu_release" and "cpufreq_cpu_acquire" are only used internally by
> drivers/cpufreq/cpufreq.c currently.
> Export them so that other drivers such as the AMD P-state driver can use them as well.
>

Can you provide more information on why this is needed for the amd-pstate driver?

This patch exports the acquire/release functions but I don't see that the amd-pstate
driver is updated to use them.

-Nathan

> Signed-off-by: Perry Yuan <Perry.Yuan@xxxxxxx>
> ---
> drivers/cpufreq/cpufreq.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 73432360e6e9..4d3c83da29b7 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -262,6 +262,7 @@ void cpufreq_cpu_release(struct cpufreq_policy *policy)
>
> cpufreq_cpu_put(policy);
> }
> +EXPORT_SYMBOL_GPL(cpufreq_cpu_release);
>
> /**
> * cpufreq_cpu_acquire - Find policy for a CPU, mark it as busy and lock it.
> @@ -291,6 +292,7 @@ struct cpufreq_policy *cpufreq_cpu_acquire(unsigned int cpu)
>
> return policy;
> }
> +EXPORT_SYMBOL_GPL(cpufreq_cpu_acquire);
>
> /*********************************************************************
> * EXTERNALLY AFFECTING FREQUENCY CHANGES *