Re: [PATCH] efs: removed useless conditional checks in function

From: Matthew Wilcox
Date: Thu Jul 07 2022 - 10:34:46 EST


On Thu, Jul 07, 2022 at 05:26:52PM +0300, Andrey Strachuk wrote:
> However, it cannot be NULL because kernel crashes at
> line 293 otherwise.
> The patch removes useless comparisons.

Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>

Not sure who's going to merge this patch. I guess I can throw it into
the pagecache tree if nobody else wants it.

> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Andrey Strachuk <strochuk@xxxxxxxxx>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

If you really want to be fancy, you can delve into linux-fullhistory and
come up with:

Fixes: 2b50c6738b500 ("Import 2.3.2")

although I bet that breaks a few scripts.